-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Prepare docs for July 2023 wave of Providers #32298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Rebased after Pydantic < 2.0.0 limit merged |
Thanks! The release wave is still on hold till we figure out the open issue of |
Which one ? |
The OL extra added to |
|
As explained in #31398, I think there are fundamentally no problems with releasing the change with openlineage extra. Our tests are passing (which also means that there are no imports that will not work becasue of openlineage missing (currently we do not install openlineage provider during tests) - so we have quite a certainty that not having openlineage provider is going to work fine for common.sql |
I think releasing an extra that you can't install is not like installing a provider with a feature that isn't useable yet and the code tells you that you can't use it (like we did with Notifiers being released in providers before we released it in core) but If others consider it as OK I will proceed with the release |
8931922 to
c782ed9
Compare
I think we won't avoid it at times - sometimes we even deliberately released something that was not usable so that we could refer to it in the future. Not ideal, but this is sometimes inevitable when we have two independent things being developed/released when usage of one will depend on the other. But if it bothers you, I can draft a very small PR to exclude it. |
|
After discussing with @potiuk I'll continue with the release as is |
|
Looks like there is issue with MsSQL tests |
Likely #32343 should fix main ( guess it's the sqlalchemy refactor). |
Providers wave for July.
open issues:
common.sqlprovider due to openlineage, common.sql: provide OL SQL parser as internal OpenLineage provider API #31398 (comment)