postgres: deprecate runtime_parameters in favor of options in hook_params
#32345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:DBs
labels
JDarDagran
force-pushed
the
postgres/use-options
branch
from
c7fe67e to
9e3ee68
Compare
JDarDagran
force-pushed
the
postgres/use-options
branch
from
9e3ee68 to
654bb44
Compare
for PostgresOperator. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
postgres/use-options
branch
from
654bb44 to
25aaba1
Compare
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you need to pass
runtime_parametersargument to explicitly set e.g. search_path in PostgresOperator.The solution IMO is not that good. It introduces use of
psycopg2.SQLwhich is not compatible withsqlattribute type.Moreover, it overcomplicates things, does not maintain same session variables outside of
PostgresOperatorexecution and would be problematic to implement when removingPostgresOperatorwhich is marked as deprecated class.Additional motivation is that I'd like to use
PostgresOperator's hook after it's execution but with the same session params in OpenLineage integration. This PR allows to do this easily.