Remove "unknown warning" check in provider verification #32444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we've been checking if there are no "unknown" warnings generated during provider import check, but this has proven to be rather useless other than occasionally annoying everone with failing main when new warnings have been introduced by a dependency. There was likely not a single time when seeing those new warnings have been actionable or useful other than adding them to the exclusion list. Removing the warning check seems to be reasonable thing to do.
eladkal
approved these changes
Jul 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we've been checking if there are no "unknown" warnings generated during provider import check, but this has proven to be rather useless other than occasionally annoying everone with failing main when new warnings have been introduced by a dependency.
There was likely not a single time when seeing those new warnings have been actionable or useful other than adding them to the exclusion list.
Removing the warning check seems to be reasonable thing to do.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.