SQL query improvements in utils/db.py #32518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move some imports to type-checking block to avoid runtime cost * Use SELECT 1 to avoid loading ORM model objects unnecessarily * Use scalars() to avoid needing to unpack ORM models * Use .c[key] instead of getattr(.c, key). They work basically the same, except getattr is worse for this purpose (potential name conflicts) * Use generators when the arguments are immediately unpacked into a function call so there's no need to produce an intermediate list
phanikumv
approved these changes
Jul 11, 2023
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #32177.
SELECT 1to avoid loading ORM model objects unnecessarilyscalars(...)to avoid needing to unpack ORM modelstable.c[key]instead of getattr(table.c, key). They work basically the same, except getattr is worse for this purpose (potential name conflicts)