Fix fetching inventory from s3 for airflow packages #32562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The apache#32495 changed the way to run docs - with using --for-production flag, which means that the docs are generated under "stable" link rather than "latest" - in order to test document publishing. We could change it back to latest, but the problem revealed that we do not have to actually make a distinction there. It's ok to keep it all as "stable" - no problem with that - there is no distinction between latest and stable other than different link and we never mix the two (our production docs have only stable), so it's ok to switch everything to stable. As a follow-up `--for-production` flag will be removed and we will switch everything to stable for all documentation building. For now fetching docs from stable link should fix the problem.
ephraimbuddy
approved these changes
Jul 12, 2023
Member
Author
|
Merging without waiting. It won't get worse. |
amoghrajesh
approved these changes
Jul 12, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. LGTM +1
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 12, 2023
We had two types of documentation building: * latest * for production But in fact they never overlapped and we were never mixing the two We used the latest for all development work and for production for releasing to "airflow.apache.org". However as we saw in apache#32562 (triggered by apache#32495 changing the build in main to run with `--for-production` flag - we actually do not need the "latest" builds at all. Everything can be build with "for production" by default. This change removes the `--for-production` flag entirely, leaving the "for production" build mode as the only one available.
potiuk
added a commit
that referenced
this pull request
Jul 12, 2023
We had two types of documentation building: * latest * for production But in fact they never overlapped and we were never mixing the two We used the latest for all development work and for production for releasing to "airflow.apache.org". However as we saw in #32562 (triggered by #32495 changing the build in main to run with `--for-production` flag - we actually do not need the "latest" builds at all. Everything can be build with "for production" by default. This change removes the `--for-production` flag entirely, leaving the "for production" build mode as the only one available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #32495 changed the way to run docs - with using --for-production flag, which means that the docs are generated under "stable" link rather than "latest" - in order to test document publishing.
We could change it back to latest, but the problem revealed that we do not have to actually make a distinction there. It's ok to keep it all as "stable" - no problem with that - there is no distinction between latest and stable other than different link and we never mix the two (our production docs have only stable), so it's ok to switch everything to stable.
As a follow-up
--for-productionflag will be removed and we will switch everything to stable for all documentation building. For now fetching docs from stable link should fix the problem.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.