-
Notifications
You must be signed in to change notification settings - Fork 16.4k
D205 Support - Utils #32591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D205 Support - Utils #32591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were four docstrings that I can't think of a way to cleanly summarize, I'd love some advice on those ones if anyone has any ideas.
The static check failures are the four I am asking for advice to change and will go away once I fix them.
edit - those comments did not work as planned. I should have seen that coming...
# Conflicts: # airflow/utils/task_group.py
|
Thanks @shubham22 , those sound great to me. I'll get those implemented some time today and push them along with the merge-conflict fix. 👍 |
Co-author: shubham22
Removed superfluous whitespace
Part of #10742
D205 asserts that all docstrings must have a one-line summary ending in a period. If there is more than one sentence then there must be a blank line before the rest of the docstring. Meeting these requirements could be as simple as adding a newline, or might require some rephrasing.
There are almost a thousand violations in the repo so we're going to have to take this in bites.
PLEASE NOTE
There should be zero changes to any functional logic or type hinting in this PR, only changes to docstrings and whitespace. If you see otherwise, please call it out.
Included in this chunk
All files in the
airflow/utilsmodule.To test
If you comment out this line and run pre-commit in main and noite the total number of errors reported by
ruff- somewhere around 253 errors. After these changes, there will be 76 fewer errors - "only" 177 as of right now - and no files in theairflow/utilsfolder should be on the list. After uncommenting that line and rerunning pre-commits, there should be zero regressions.