Revising instructions to run back referencing scripts #32613
Conversation
|
@potiuk looks to me that this is the final PR to wind up the issue :) |
dev/README_RELEASE_AIRFLOW.md
Outdated
| cd post-docs | ||
| python add-back-references.py airflow | ||
| cd .. | ||
| breeze release-management add-back-references --airflow-site-director DIRECTORY --gen-type airflow |
There was a problem hiding this comment.
You should not add the flag here. Those are real copy-pasteable instructions, it should just-work
You should remove the flags, and ENVVAR will kick in here. If you look up AIRLFOW_SITE_DIRECTORY is set few steps above , so just running it without the flag should work here (and in the other places).
There was a problem hiding this comment.
Okay makes sense. Corrected it!
There was a problem hiding this comment.
What I mean is to remove the flag altogether - this is how it works
| cd "${AIRFLOW_SITE_DIRECTORY}" | ||
| cd post-docs | ||
| python add-back-references.py providers | ||
| breeze release-management add-back-references --airflow-site-directory --gen-type providers |
There was a problem hiding this comment.
this doesn't work for me
➜ airflow-site git:(main) ✗ breeze release-management add-back-references --airflow-site-directory --gen-type providers
Usage: breeze release-management add-back-references [OPTIONS]
Try running the '--help' flag for more information.
╭─ Error ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Missing option '-g' / '--gen-type'. │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
To find out more, visit https://github.com/apache/airflow/blob/main/BREEZE.rst
There was a problem hiding this comment.
Thanks for reporting
I will have a look at it and fix it soon if there's an issue
There was a problem hiding this comment.
Can you try without the --airflow-directory? What does it complain?
There was a problem hiding this comment.
Yes --airflow-site-directory is a clear problem. It treats --gen-dir as value of the --airflow-site-directory
There was a problem hiding this comment.
Yeah, i have fixed this in a follow up PR
3 participants
Revising the instructions on how to run the back referring scripts now that it is present with breeze