Add option for storing configuration description in providers #32629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly for the capacity of adding configuration to provider.yaml files. This change adds capavilty of adding "config" option to provider yaml and provider_info. This is not yet used, but it has been extracted as separate PR from apache#32604 in an attempt to make it more reviewable and readable.
uranusjr
reviewed
Jul 16, 2023
Member
There was a problem hiding this comment.
This entire file is reindented, likely unintended
Member
Author
There was a problem hiding this comment.
Yep. It had inconsistent indentation to begin with so I re-indented it to be fully consistent. I could separate it out like "indent those provider.json.schemas". but I figured that with such a big addition it makes sense to do it in one PR - especially that it has very little "code" in them - it's merely a description that is used to validate the real code.
Do you think it's better to split it ? I am happy to do it if you think it makes sense @uranusjr :)
hussein-awala
approved these changes
Jul 16, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
It looks good! And yes, this completely removes my concerns explained in 32628
LGTJM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for the capacity of adding configuration to provider.yaml files.
This change adds capavilty of adding "config" option to provider yaml and provider_info. This is not yet used, but it has been extracted as separate PR from #32604 in an attempt to make it more reviewable and readable.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.