Skip to content

Conversation

@stelsemeyer-m60
Copy link
Contributor

Parametrize the interval in which the Kubernetes pod status is polled when launching a new pod using the already existing poll_interval parameter.

When using serverless Kubernetes services like Google GKE Autopilot the pod startup time is sometimes expected to be longer due to a cold start. Therefore the logs might be spammed due to the default checks every second (see below), and a lower check frequency might be desired

[2023-05-02, 05:33:22 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:23 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:24 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:25 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:26 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:27 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:28 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:29 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:30 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:31 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:32 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:33 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:34 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:35 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:36 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
[2023-05-02, 05:33:37 UTC] {pod_manager.py:187} WARNING - Pod not yet started: some-pod-he2j8139
...

This addresses comments in #31008 (having duplicated logic, not fully functional new implementation).
cc @jedcunningham @potiuk

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers kind:documentation provider:google Google (including GCP) related issues labels Jul 16, 2023
@stelsemeyer-m60 stelsemeyer-m60 changed the title Poll interval improvement Parametrize poll_interval in KubernetesPodOperator Jul 16, 2023
@amoghrajesh
Copy link
Contributor

@stelsemeyer-m60 Why was this closed? Is it not applicable anymore?

@stelsemeyer-m60
Copy link
Contributor Author

@stelsemeyer-m60 Why was this closed? Is it not applicable anymore?

This is a duplicate of #31008, with a pending discussion.

@amoghrajesh
Copy link
Contributor

I see. The PR was closed due to no activity.

How do you plan to follow up on it?

@stelsemeyer-m60
Copy link
Contributor Author

stelsemeyer-m60 commented Aug 9, 2023

I see. The PR was closed due to no activity.

How do you plan to follow up on it?

Would be great to get feedback on my last reply (in that PR). Otherwise I can also make an educated guess/decision. My time is limited at the moment, but I still plan to finish that PR.

@potiuk
Copy link
Member

potiuk commented Aug 9, 2023

I see. The PR was closed due to no activity.
How do you plan to follow up on it?

Would be great to get feedback on my last reply (in that PR). Otherwise I can also make an educated guess/decision. My time is limited at the moment, but I still plan to finish that PR.

Small uggestion - in case it is not clear @stelsemeyer-m60: I suggest (and our CONTRIBUTING docs already explain that) to regular (but not too frequent - use your own judgment taking into account that people look at those in their private time and can be busy/on holidays etc.) gently pinging when you wait for answer.

It's SUPER easy to miss someone's question or explanation, and when you take into accounts that we merge 30-40 PRs a day and have 150 opened PRs and many more issues commented on, the fact that you asked a question might be easily missed. If you look at this from the other side - you have one PR that you care about and maintainers have at the same time 100s of conversations going on, it's quite a bit obvious that it's on the side of author to make sure to follow up if they want to make things happen :). This also shows that you do, actually care, and have not abandoned it (which happens more often than you think).

Just a friendly tip.

@stelsemeyer-m60
Copy link
Contributor Author

I see. The PR was closed due to no activity.
How do you plan to follow up on it?

Would be great to get feedback on my last reply (in that PR). Otherwise I can also make an educated guess/decision. My time is limited at the moment, but I still plan to finish that PR.

Small uggestion - in case it is not clear @stelsemeyer-m60: I suggest (and our CONTRIBUTING docs already explain that) to regular (but not too frequent - use your own judgment taking into account that people look at those in their private time and can be busy/on holidays etc.) gently pinging when you wait for answer.

It's SUPER easy to miss someone's question or explanation, and when you take into accounts that we merge 30-40 PRs a day and have 150 opened PRs and many more issues commented on, the fact that you asked a question might be easily missed. If you look at this from the other side - you have one PR that you care about and maintainers have at the same time 100s of conversations going on, it's quite a bit obvious that it's on the side of author to make sure to follow up if they want to make things happen :). This also shows that you do, actually care, and have not abandoned it (which happens more often than you think).

Just a friendly tip.

Absolutely understandable. Thanks for outlining this, and the tip, @potiuk.

I should have checked CONTRIBUTING doc more carefully. Sometimes mature open source projects are a bit overwhelming, especially when you just want to make a small adjustment that you feel is fair and without risk. Anyways, that shall not be an excuse but maybe rather an additional perspective. I totally get your point and you are absolutely right.

I will follow up on the ticket and go ahead as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants