Move webserver config writing to main #32766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
provider:cncf-kubernetes
potiuk
requested review from
eladkal,
ephraimbuddy,
hussein-awala and
jedcunningham
potiuk
force-pushed
the
move-webserver-config-writing-to-main
branch
6 times, most recently
from
aa5eb07 to
1901a57
Compare
potiuk
force-pushed
the
move-webserver-config-writing-to-main
branch
from
1901a57 to
c493a79
Compare
So far configuration was automatically written no matter what command has been invoked. This means tha webserver configuration is stored for all components, where it was only really needed for webserver. This small change moves the place where configuration writing is invoked - webserver configuration will only be automatically checked for and written when webserver command has been invoked via __main__ entrypoint. This has also the nice side-effect that it is not written during tests, or when airflow is just imported.
potiuk
force-pushed
the
move-webserver-config-writing-to-main
branch
from
c493a79 to
b06f29f
Compare
ephraimbuddy
approved these changes
Jul 22, 2023
hussein-awala
approved these changes
Jul 22, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 24, 2023
We are also using webserver config when we start worker and in the future the internal-api server - which was not happening after apache#32766. This PR brings the webserver config back for those commands.
potiuk
added a commit
that referenced
this pull request
Jul 24, 2023
We are also using webserver config when we start worker and in the future the internal-api server - which was not happening after #32766. This PR brings the webserver config back for those commands.
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far configuration was automatically written no matter what command
has been invoked. This means tha webserver configuration is stored
for all components, where it was only really needed for webserver.
This small change moves the place where configuration writing is
invoked - webserver configuration will only be automatically
checked for and written when webserver command has been invoked
via main entrypoint.
This has also the nice side-effect that it is not written during
tests, or when airflow is just imported.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.