Extract Dask executor to daskexecutor provider #32769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of commands in Airflow relies on the fact that providers configuration is loaded. This is a rather fast operation as it does not involve any importing of provider classes, just discovering entrypoints, running them and parsing yaml configuration, so it is a very low sub-second time to do it. We cannot do it once in settings/config because we actually need settings/config to be pre-initialized without providers in order to be able to bootstrap airflow, therefore we need to run it individually in each command that can be run with the "airflow" entrypoint. Decorator seems to be best suited to do the job: * easy to apply and not easy to forget when you create another command and look at other commands * nicely wraps around local ProvidersManager import There are exceptions for the "version" and "providers lazy-loaded" commands because they are NOT supposed to initialize configuration of providers.
potiuk
requested review from
XD-DENG,
ashb,
dstandish,
kaxil,
o-nikolas and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:CLI
area:dev-tools
provider:cncf-kubernetes
potiuk
requested review from
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham and
mobuchowski
Member
Author
|
Based on #32765 so only last commit counts. |
potiuk
commented
Jul 22, 2023
setup.py
Outdated
Member
Author
There was a problem hiding this comment.
Separate commit will clean up and move all three celery, kubernetes, dask out of here (and in the docs). They are not needed.
potiuk
force-pushed
the
create-dask-executor-provider
branch
from
3835fd0 to
064c90c
Compare
Member
Author
|
Closing and reopening one in Airflow Repo. This one changes some of the values that are taken from main branch (list of providers to build and list of default extras), so I need to make the PR from airflow repo, not from fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.