Remove atlas config #32776
Merged
Remove atlas config #32776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
provider:cncf-kubernetes
Member
Author
Atlas does not have its own provider, the only thing we have with atlas extra is an extra dependency to atlasclient. Abd we also had the atlas configuration for some reason that even the eldest don't know. With hard-coded defaults, we are still keeping backwards compatibility if someone used those values. However we should remove it from "core" configuration because it has absolutely no meaning for Airflow. Users are free to define their own sections and variables following Airflow schema and this squarely fits into this category.
potiuk
force-pushed
the
remove-atlas-config
branch
from
e57d629 to
63cd88e
Compare
jedcunningham
approved these changes
Jul 24, 2023
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atlas does not have its own provider, the only thing we have with
atlas extra is an extra dependency to atlasclient. Abd we also had
the atlas configuration for some reason that even the eldest don't
know. With hard-coded defaults, we are still keeping backwards
compatibility if someone used those values. However we should
remove it from "core" configuration because it has absolutely no
meaning for Airflow. Users are free to define their own sections
and variables following Airflow schema and this squarely fits into
this category.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.