Improve typing for providers config loader #32782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
approved these changes
Jul 23, 2023
potiuk
approved these changes
Jul 23, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
I don't understand a single bit of it, but looks cool. Adding to my learning toolbox :D
Member
|
@potiuk We use the same syntax in the session utils https://github.com/apache/airflow/blob/main/airflow/utils/session.py |
Member
|
Yeah. I know :) . I just would love to understand it deeply. The Typing system of Python has some dark corners I did not have time to explore. |
Member
|
Yet |
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stricter types for
providers_configuration_loadedand remove unnecessarycastcall.related: #32765