Fix failing dagrun query due to sqlalchemy 2.0 refactor #32801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in refactoring this query but the code had no test coverage. This commit fixes it and adds a test to cover this part of the code
ephraimbuddy
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
ephraimbuddy
added
the
changelog:skip
phanikumv
changed the title
phanikumv
approved these changes
Jul 24, 2023
uranusjr
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in refactoring this query but the code had no test coverage. This commit fixes it and adds a test to cover this part of the code
Related to #32350