-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix link_names parameter not being passed to hook in SlackWebhookOperator
#32919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check STATIC_CODE_CHECKS doc to fix the failed test
| # Unused Parameters, warn user if not None | ||
| **({"link_names": self.link_names} if self.link_names else {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a unit test to ensure that the argument is not provided when it's False?
link_names if it is not Falsylink_names parameter not being passed to hook in SlackWebhookOperator
|
I have been unable to get Breeze to build successfully so far. I'll keep trying, but it may take some time. If anyone wants to help, it would be appreciated. |
I wonder what errors you had ? |
| # Unused Parameters, warn user if not None | ||
| **({"link_names": self.link_names} if self.link_names else {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Unused Parameters, warn user if not None | |
| **({"link_names": self.link_names} if self.link_names else {}), |
AFAIK I mark this value as not used for about I year, so we could just remove provide it in to the hook.
|
@kojiromike |
Only pass link_names if it has a non-Falsy value
Resolve #32917 by ensuring that SlackWebhookOperator only passes
link_namesto SlackWebhookHook if it has a non-Falsy value.