Split PROD image verification to a separate step in CI #33140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PROD image verification happens after the images are pulled in the "wait for PROD images" step. This verification is pretty helpful in detecting cases where there are some "installed airflow" problems (for example recently it helped to avoid a circular import problem in apache#33081 as one of the tests failed when images were verified. However PROD image wait might fail for other reasons and sometimes might be "neglected" as temporary failure. Separating verification will allow to clearly surface that the problem is with verification, not pulling the images.
potiuk
requested review from
amoghrajesh,
ferruzzi,
hussein-awala,
pankajastro,
pankajkoti and
phanikumv
pankajastro
approved these changes
Aug 5, 2023
phanikumv
reviewed
Aug 5, 2023
Contributor
phanikumv
left a comment
phanikumv
left a comment
There was a problem hiding this comment.
observing few CI failures
Member
Author
|
Yeah. Our CI framework got pretty unstable recently. I hope with apache/airflow-ci-infra#59 of @hussein-awala we will finally be able to get it under better control (but due to 2.7 I did not have time to look at it yet - hopefully soon). |
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 8, 2023
The PROD image verification happens after the images are pulled in the "wait for PROD images" step. This verification is pretty helpful in detecting cases where there are some "installed airflow" problems (for example recently it helped to avoid a circular import problem in #33081 as one of the tests failed when images were verified. However PROD image wait might fail for other reasons and sometimes might be "neglected" as temporary failure. Separating verification will allow to clearly surface that the problem is with verification, not pulling the images. (cherry picked from commit c310703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PROD image verification happens after the images are pulled in the "wait for PROD images" step. This verification is pretty helpful in detecting cases where there are some "installed airflow" problems (for example recently it helped to avoid a circular import problem in #33081 as one of the tests failed when images were verified. However PROD image wait might fail for other reasons and sometimes might be "neglected" as temporary failure.
Separating verification will allow to clearly surface that the problem is with verification, not pulling the images.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.