Fix handling of default value and serialization of Param class #33141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
XD-DENG,
ashb,
bolkedebruin and
kaxil
as code owners
jscheffl
changed the title
eladkal
added
type:bug-fix
uranusjr
approved these changes
Aug 16, 2023
hussein-awala
approved these changes
Aug 16, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 489ca14)
97 tasks
2 tasks
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Split PR form #31301 to reduce volume and concerns --
This PR fixes the behavior of the
Paramclass and resolves problems found while implementing #31301. Problems found there:Paramobject theArgNotSetObject was passed out as value whendump()was called - now if no default is provided, this is now masked withNone.Nonewas provided as default the check forhas_valuereturnedTruewhich is not really expected.Paramand the value was initialized toArgNotSetthen during DAG serialization the object in the value was converted to a string representation. Upon de-serialization aParamwith no default came out with the default value<airflow.utils.types.ArgNotSet object at 0x7fb1c6344c40>as string. Fixed serialization and now theArgNotSetobject is supported to be serialized/deserialized properly.Adjusted pytests accordingly to prevent a regression.