Ensure include_deferred is not nullable #33280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a multi-step process to introduce the NOT NULL constraint to the column, needed due to MSSQL restrictions.
This is fine. SQL is fun.
airflow/migrations/versions/0128_2_7_0_add_include_deferred_column_to_pool.py
Outdated
Show resolved
Hide resolved
ephraimbuddy
approved these changes
Aug 10, 2023
potiuk
approved these changes
Aug 10, 2023
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 10, 2023
* Ensure include_deferred is not nullable This uses a multi-step process to introduce the NOT NULL constraint to the column, needed due to MSSQL restrictions. * MSSQL does not even support boolean literals * Postgres does not support 0 as boolean This is fine. SQL is fun. * Wrap raw SQL in text() (cherry picked from commit 4f6d597)
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
* Ensure include_deferred is not nullable This uses a multi-step process to introduce the NOT NULL constraint to the column, needed due to MSSQL restrictions. * MSSQL does not even support boolean literals * Postgres does not support 0 as boolean This is fine. SQL is fun. * Wrap raw SQL in text()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a multi-step process to introduce the NOT NULL constraint to the column, needed due to MSSQL restrictions.
See #32709 and #33271.