Fix get_log_events() in AWS logs hook #33290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
syedahsn
approved these changes
Aug 10, 2023
Contributor
syedahsn
left a comment
syedahsn
left a comment
There was a problem hiding this comment.
Ah I was looking for the fix, but this was a sneaky one. LGTM
o-nikolas
approved these changes
Aug 10, 2023
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
This is a sneaky one! Got passed PR review but our AWS System tests caught the issue which is super cool 😎
Member
😎😎😎😎😎 |
potiuk
approved these changes
Aug 10, 2023
Member
Those are the moments that you know where months of investments can save you weeks of pulling your hair in despair. I know all about it. |
eladkal
approved these changes
Aug 10, 2023
Contributor
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
Just in time for the RC!
25 tasks
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33231 was not backward compatible because you can call
get_log_eventswith positional parameters. When doing so, you get an error because I addedend_timeafterstart_timewhich, when using positional parameters, it is supposed to beskip.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.