Remove supports_ad_hoc_ti_run from executor API
#33397
Conversation
The run task instance capability was removed from the Airflow UI and API in apache#29706 but the base executor interface and subclasses which support it was not updated.
o-nikolas
requested review from
XD-DENG,
ashb,
hussein-awala,
jedcunningham,
kaxil and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:providers
area:Scheduler
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
-0 from me for this change.
(I won't get in the way, but I'd rather we didn't do this)
| :param parallelism: how many jobs should run at one time. Set to ``0`` for infinity. | ||
| """ | ||
|
|
||
| supports_ad_hoc_ti_run: bool = False |
There was a problem hiding this comment.
BaseExecutor is a part of the public interface of Airflow, is it safe to remove this config?
We don't use this config in Airflow, but we don't know if the users use it in custom plugins or custom executors.
There was a problem hiding this comment.
I tend to agree; maybe a deprecation would be better.
There was a problem hiding this comment.
The Run task api/UI feature was certainly public and we ripped that out without too much worry.
I don't think there will be any impact for removing this relatively obscure field that was not used elsewhere. What we uphold to the public is that this interface, when implemented, will plug into Airflow. Worrying about removing this particular field is falling prey to XKCD 1172 IMHO.
3 participants
The run task instance capability was removed from the Airflow UI and API in #29706 but the base executor interface and subclasses which support it was not updated.
supports_ad_hoc_ti_runwas only used in the run task logic so it can now be removed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.