-
Notifications
You must be signed in to change notification settings - Fork 16.4k
feat(providers/microsoft): add DefaultAzureCredential to data_lake #33433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers/microsoft): add DefaultAzureCredential to data_lake #33433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post a screenshot of a task working successfully with the DefaultAzureCredential that you introduced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll test and post a screenshot before I mark these PRs as read to review
bb709df to
edf4d99
Compare
edf4d99 to
ea7306f
Compare
phanikumv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add example DAG for this change and unit tests as well
I'm using the existing DAG for the testing, and I don't expect code changes to be needed on the DAG. And yes, I'll add some unit tests |
ea7306f to
3c9b1f7
Compare
Does the existing DAG make use of DefaultAzureCredential? |
Whether to use |
8aeae8d to
0845088
Compare
|
Just add some unit tests |
6e88267 to
74a2750
Compare
…edentialAdapter support to data_lake
…ity_credential_adppter_when_tenant_is_not_provided
74a2750 to
ac2be8c
Compare
|
@phanikumv -> are you good with it ? |


This PR depends on #33687
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.