Refactor: Simplify conditions on len() #33454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eumiro
requested review from
XD-DENG,
ashb,
bbovenzi,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk,
ryanahamilton and
uranusjr
as code owners
boring-cyborg
bot
added
area:CLI
area:providers
area:Scheduler
uranusjr
reviewed
Aug 17, 2023
uranusjr
reviewed
Aug 17, 2023
scripts/ci/pre_commit/pre_commit_check_system_tests_hidden_in_index.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Aug 17, 2023
uranusjr
approved these changes
Aug 17, 2023
eumiro
force-pushed
the
simplify-len
branch
4 times, most recently
from
570ba81 to
2b6773b
Compare
Member
|
Neds conflict resolution/fixing tests. |
Contributor
Author
|
@potiuk I will split it into smaller PRs. This one will keep only the last commit for files that did not fit any other specific commit. |
eumiro
force-pushed
the
simplify-len
branch
2 times, most recently
from
853d2d4 to
15ebe06
Compare
jedcunningham
approved these changes
Aug 22, 2023
potiuk
approved these changes
Aug 22, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit e434ae8)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the changes are atomic within a line or a group of lines. I have split the changes into 9 regional commits and posted them within one PR, but if you wish, I can split them into 9 PRs.