-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Update list_jobs function in DatabricksHook to token-based pagination
#33472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
What is |
Tracking ticket from Databricks side, nevermind |
f60fa07 to
16d9232
Compare
alexott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good - can we add a unit test for token usage?
|
Added test @alexott, PTAL! |
alexott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@eladkal WDYT?
91d173e to
7ff7fc8
Compare
|
Hi @eladkal, could you please take another look? |
|
LGTM @eladkal ? |
2c6add3 to
c8c1c0f
Compare
276cdec to
fb5fd82
Compare
|
Heyy @eladkal , I have updated the tests/formatting, can we pls merge? |
list_jobs function in DatabricksHook to token-based pagination
|
@oleksiidav static checks are failing you are missing import of |
|
Static check to fix. |
Until offset deprecation
0dded80 to
85df103
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Update Airflow to switch from default offset-based pagination (deprecated) to using a page token