Fix KubernetesPodOperator duplicating logs when interrupted #33500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Contributor
|
@fdemiane is it ready for review? |
kosteev
approved these changes
Aug 22, 2023
Contributor
Author
amoghrajesh
approved these changes
Aug 23, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
This looks pretty good +1
potiuk
approved these changes
Aug 24, 2023
This was referenced Aug 25, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KubernetesPodOperator is duplicating logs when they are interrupted. When calling _client.read_namespaced_pod_log, we were passing an outdated since_seconds: we were not using the latest captured timestamp when computing since_seconds.
closes: #33498