Refactor: Do not create lists we don't need #33519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eumiro
requested review from
ashb,
hussein-awala,
jedcunningham and
potiuk
as code owners
boring-cyborg
bot
added
area:CLI
area:dev-tools
area:providers
area:webserver
eumiro
force-pushed
the
fewer-lists
branch
2 times, most recently
from
4b3d738 to
70abde4
Compare
uranusjr
reviewed
Aug 20, 2023
uranusjr
reviewed
Aug 20, 2023
Member
There was a problem hiding this comment.
Hmm, this test seems wrong actually. The current logic checks there’s at least one task with no deps set, but the comment suggests it should instead test that no deps are set at all.
@ephraimbuddy (author of this) can you confirm which is the original intention here?
Contributor
There was a problem hiding this comment.
Not really wrong but can be improved. We should assert that non of the tasks have dependencies probably by checking the total tasks without dependencies:
assert len([x for x in dag.tasks if not x.downstream_list])==6
uranusjr
approved these changes
Aug 24, 2023
potiuk
approved these changes
Aug 24, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 4154cc0)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all these cases, complete lists are created although only their length or the first element are needed. This PR introduces shortcuts.