Skip to content

Conversation

@Tagar
Copy link
Contributor

@Tagar Tagar commented May 16, 2018

Make sure you have checked all steps below.

JIRA

Description

  • As discussed on the dev list, tabulate==0.8.2 is good to go with Airflow

Tests

  • tested manually

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

@r39132
Copy link
Contributor

r39132 commented May 17, 2018

@Tagar why do you have 2 commits? Why is the second one adding a dependency? Pls squash your commits. Also, provide a little more context on this upgrade in the JIRA.

@kaxil
Copy link
Member

kaxil commented May 29, 2018

@Tagar Can you please squash commits? and as Sid requested can you please provide a little more details on this upgrade in the JIRA?

@r39132
Copy link
Contributor

r39132 commented Aug 30, 2018

@Tagar kindly rebase

@Tagar
Copy link
Contributor Author

Tagar commented Sep 2, 2018

@r39132 sorry for the delay. I've moved to some other projects and don't have airflow handy to fix this. if somebody can take over this PR, this will be totally fine with me. Thanks!

@kaxil
Copy link
Member

kaxil commented Sep 2, 2018

No worries @Tagar, thanks anyways . Closed in favor of #3835

@kaxil kaxil closed this Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants