Refactor: Improve detection of duplicates and list sorting #33675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eumiro
requested review from
ashb,
hussein-awala,
jedcunningham and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
area:logging
area:providers
provider:cncf-kubernetes
uranusjr
reviewed
Aug 24, 2023
| with DAG( | ||
| dag_id=Path(__file__).stem, | ||
| description=__doc__[0 : __doc__.find(".")], | ||
| description=__doc__.partition(".")[0], |
Member
There was a problem hiding this comment.
Not totally related but gosh I’m not sure we should encourage this pattern.
Member
There was a problem hiding this comment.
It does have an appeal, especially if you consider the D400 rule of pydoc style.
uranusjr
reviewed
Aug 24, 2023
Comment on lines
+322
to
+328
| count_integrations = Counter(r.get("integration-name", "") for r in resource_data) | ||
| for integration, count in count_integrations.items(): | ||
| if count > 1: | ||
| errors.append( | ||
| f"Duplicated content of '{resource_type}/integration-name/{integration}' " | ||
| f"in file: {yaml_file_path}" | ||
| ) |
Member
There was a problem hiding this comment.
I wonder if this should just use ["integration-name"] instead of .get(). This would emit a nonsensical message when the key is missing anyway…
uranusjr
approved these changes
Aug 24, 2023
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Logic-related changes mentioned above will be proposed in a separate PR for discussion.
potiuk
approved these changes
Aug 24, 2023
Member
|
Flaky test only - merging. |
34 tasks
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 2dbb963)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.