Inspect container state rather than last_state when deciding whether to skip #33702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWheating
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
potiuk
approved these changes
Aug 24, 2023
potiuk
reviewed
Aug 24, 2023
| assert self.expected_pod["spec"] == actual_pod["spec"] | ||
| assert self.expected_pod["metadata"]["labels"] == actual_pod["metadata"]["labels"] | ||
|
|
||
| def test_skip_on_specified_exit_code(self, mock_get_connection): |
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #33697
Looking at the Kubernetes API Docs for containerStatus, it looks like
lastStateprovides the state of the previous run of the container, whereasstateshould provide information on the most recent termination (which is the relevant one in this case)I also added an integration test under
kubernetes_teststo verify that this works as expected.