Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented May 18, 2018

Make sure you have checked all steps below.

JIRA

  • My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

- Replace incorrect `this.log` keyword for logging of Qubole Sensor to `self.log`
I am sure #3297 (comment) was suppose to mean `self.log.info` instead of `this.log.info`.
@kaxil
Copy link
Member Author

kaxil commented May 18, 2018

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaxil for fixing this

cc @cclauss

@asfgit asfgit closed this in f297a03 May 18, 2018
@kaxil kaxil deleted the AIRFLOW-2485 branch May 19, 2018 15:41
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
- Replace incorrect `this.log` keyword for logging
of Qubole Sensor to `self.log`
I am sure https://github.com/apache/incubator-
airflow/pull/3297#issuecomment-385988083 was
suppose to mean `self.log.info` instead of
`this.log.info`.

Closes apache#3378 from kaxil/AIRFLOW-2485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants