Add Amazon SNS Notifier #33828
Merged
Add Amazon SNS Notifier #33828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon
vincbeck
reviewed
Aug 28, 2023
| ) | ||
|
|
||
|
|
||
| send_sns_notification = SnsNotifier |
Contributor
There was a problem hiding this comment.
Why is it needed? Could not we just call directly SnsNotifier?
Contributor
Author
There was a problem hiding this comment.
Same convention in other notifiers ¯\_(ツ)_/¯.
And this conventions was here since first notifier implemented, I know because this PR sits in my local machine for a long time I've just waited until 2.6 released... and have a time to push it only now.
Contributor
There was a problem hiding this comment.
I am not against it but I dont feel it is necessary and bring more complexity by adding a proxy name ¯_(ツ)_/¯
Contributor
Author
There was a problem hiding this comment.
I've tried to find why initially we decide to use snake_case for notifiers, but with no luck
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
vincbeck
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
SnsNotifieras part of Amazon Provider^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.