Chart: Add scheduler name to PODs templates #33843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolvery
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
wolvery
changed the title
wolvery
force-pushed
the
feature/add-scheduler-name
branch
2 times, most recently
from
1cac8b2 to
04be06e
Compare
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Could you add a unit test for each deployment?
amoghrajesh
reviewed
Aug 31, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Good idea. Can you add some unit test coverage for this?
jedcunningham
approved these changes
Sep 7, 2023
hussein-awala
approved these changes
Sep 7, 2023
wolvery
force-pushed
the
feature/add-scheduler-name
branch
from
c83fa81 to
b8b193d
Compare
24 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature aims to enable the possibility to define a SchedulerName different than "Default".
With this feature, we are able to define some particular schedulers from Kubernetes to apply some different strategies to allocate resources.
More info in this link: https://kubernetes.io/docs/tasks/extend-kubernetes/configure-multiple-schedulers/