Refactor unneeded 'continue' jumps around the repo #33849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:plugins
area:Scheduler
eumiro
requested review from
XD-DENG,
ashb,
bolkedebruin,
hussein-awala,
kaxil,
o-nikolas and
pierrejeambrun
as code owners
o-nikolas
reviewed
Aug 29, 2023
Comment on lines
825
to
828
Contributor
There was a problem hiding this comment.
Is this really any better/more clear?
Contributor
Author
There was a problem hiding this comment.
It keeps the v variable in the successful try/else line. But I'll revert it here.
o-nikolas
approved these changes
Aug 31, 2023
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
These types of PRs are always tricky to brain compile perfectly. But I don't spot any behaviour changes and the tests are passing. So LGTM 👍
eumiro
force-pushed
the
continue-misc
branch
from
3df3cdd to
5a4b7a3
Compare
potiuk
approved these changes
Sep 4, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 668aace)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.