replace unnecessary dict comprehension by dict() in core #33858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
XD-DENG,
ashb,
bbovenzi,
ephraimbuddy,
kaxil,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
hussein-awala
changed the title
uranusjr
reviewed
Aug 29, 2023
uranusjr
reviewed
Aug 29, 2023
airflow/operators/python.py
Outdated
|
|
||
| def _execute_python_callable_in_subprocess(self, python_path: Path, tmp_dir: Path): | ||
| op_kwargs: dict[str, Any] = {k: v for k, v in self.op_kwargs.items()} | ||
| op_kwargs: dict[str, Any] = dict(self.op_kwargs.items()) |
Member
There was a problem hiding this comment.
Suggested change
| op_kwargs: dict[str, Any] = dict(self.op_kwargs.items()) | |
| op_kwargs: dict[str, Any] = self.op_kwargs.copy() |
Member
Author
There was a problem hiding this comment.
op_kwargs type is Mapping that doesn't have copy() method
Member
There was a problem hiding this comment.
Then dict(self.op_kwargs) should work, I think.
uranusjr
reviewed
Aug 29, 2023
uranusjr
reviewed
Aug 29, 2023
uranusjr
reviewed
Aug 29, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
reviewed
Aug 30, 2023
Taragolis
reviewed
Aug 31, 2023
| lineage[meta.task_id]["outlets"] = meta.value | ||
|
|
||
| return {"task_ids": {k: v for k, v in lineage.items()}} | ||
| return {"task_ids": lineage.copy()} |
Contributor
There was a problem hiding this comment.
Suggested change
| return {"task_ids": lineage.copy()} | |
| return {"task_ids": dict(lineage)} |
Otherwise you've got a copy of defaultdict rather than dict
Member
There was a problem hiding this comment.
Don’t think that’d be problematic though?
Member
Author
There was a problem hiding this comment.
I agree with @Taragolis, I should avoid any change in the values in this refactor PR
Taragolis
approved these changes
Sep 10, 2023
uranusjr
approved these changes
Sep 11, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 6a33d05)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.