Skip to content

Conversation

@rodrigc
Copy link
Contributor

@rodrigc rodrigc commented May 20, 2018

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Bump up celery to >= 4.1.1 to get dependency on kombu >= 4.2.0

This allows broker_url with sqla to work. kombu 4.0.2 does not support sqla urls.

Make sure you have checked all steps below.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

Codecov Report

Merging #3388 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3388   +/-   ##
=======================================
  Coverage   76.49%   76.49%           
=======================================
  Files         203      203           
  Lines       15019    15019           
=======================================
  Hits        11489    11489           
  Misses       3530     3530

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc78b91...87f220b. Read the comment docs.

This also updates the kombu dependency to >= 4.2.0.
This allows broker_url with sqlalchemy urls to work.
@rodrigc rodrigc changed the title [AIRFLOW-2495] setup.py extras for celery should depend on kombu >= 4.1.0 [AIRFLOW-2495] Bump up celery to >= 4.1.1 to get dependency on kombu >= 4.2.0 May 21, 2018
@kaxil
Copy link
Member

kaxil commented May 21, 2018

LGTM. The errors in CI look unrelated

@asfgit asfgit closed this in 4fc61a3 May 21, 2018
@rodrigc
Copy link
Contributor Author

rodrigc commented May 21, 2018

@kaxil Thanks for merging. What is the procedure to merge this to v1-10-test?
I am doing extensive testing of that branch now, and need this fix in that branch. Thanks again.

cloneluke pushed a commit to cloneluke/incubator-airflow that referenced this pull request May 30, 2018
…tay under 4.2.0 until that and/or 5.0 is tested.

[AIRFLOW-1840]
apache#2806
also related to apache#3388
[AIRFLOW-2495]
@cloneluke
Copy link
Contributor

#3437

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
This also updates the kombu dependency to >=
4.2.0.
This allows broker_url with sqlalchemy urls to
work.

Closes apache#3388 from rodrigc/AIRFLOW-2495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants