Skip to content

replace loop by any when looking for a positive value in core #33985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Sep 1, 2023
Merged

replace loop by any when looking for a positive value in core #33985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions airflow/www/extensions/init_appbuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,10 +645,7 @@ def register_blueprint(self, baseview, endpoint=None, static_folder=None):
)

def _view_exists(self, view):
for baseview in self.baseviews:
if baseview.__class__ == view.__class__:
return True
return False
return any(baseview.__class__ == view.__class__ for baseview in self.baseviews)

def _process_inner_views(self):
for view in self.baseviews:
Expand Down
5 changes: 1 addition & 4 deletions airflow/www/fab_security/sqla/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,4 @@ def filter_roles_by_perm_with_action(self, action_name: str, role_ids: list[int]
).all()

def perms_include_action(self, perms, action_name):
for perm in perms:
if perm.action and perm.action.name == action_name:
return True
return False
return any(perm.action and perm.action.name == action_name for perm in perms)