Bring back SHUTDOWN-related constants #34063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Sep 4, 2023
Member
|
Pending test fixes |
uranusjr
force-pushed
the
bring-back-shutdown-values
branch
from
ed5a9fc to
fce7f86
Compare
Lee-W
reviewed
Sep 4, 2023
uranusjr
force-pushed
the
bring-back-shutdown-values
branch
2 times, most recently
from
82eb4df to
64059a8
Compare
This should restore code compatibility to 2.6 and prior. Note that the constants would not appear in documentation since they are deprecated and not use in Airflow core anyway anymore.
uranusjr
force-pushed
the
bring-back-shutdown-values
branch
from
64059a8 to
31f65d1
Compare
daniel-dylag-openx
approved these changes
Sep 4, 2023
Contributor
daniel-dylag-openx
left a comment
daniel-dylag-openx
left a comment
There was a problem hiding this comment.
The failing test is a known flaky test so re-run or merge with main might fix it
Member
BTW. I think I fixed the flaky test in #34075 so likely rebasing it woudl be flaky-free, but I re-run those failing tests now. |
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
This should restore code compatibility to 2.6 and prior. Note that the constants would not appear in documentation since they are deprecated and not use in Airflow core anyway anymore. (cherry picked from commit 1ae2976)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should restore code compatibility to 2.6 and prior. Note that the constants would not appear in documentation since they are deprecated and not use in Airflow core anyway anymore.
See discussion around #33746 (comment)
The value on
JobStatewas not brought back since that particular enum was only added in 2.7 and should not technically cause any compatibility issues. I also added some additional docstrings so those constants would not appear in documentation added in #34059. Those who already know about the values can continue to use them, but this should reduce additional usages.