Refactor: Simplify string generation #34118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:cncf-kubernetes
eumiro
force-pushed
the
string-generation
branch
from
f911a12 to
8b4771e
Compare
uranusjr
reviewed
Sep 5, 2023
uranusjr
reviewed
Sep 6, 2023
eumiro
requested review from
ashb,
dstandish,
eladkal,
hussein-awala,
jedcunningham,
o-nikolas and
potiuk
as code owners
eumiro
force-pushed
the
string-generation
branch
from
8b4771e to
c9777aa
Compare
uranusjr
reviewed
Sep 7, 2023
uranusjr
reviewed
Sep 7, 2023
eumiro
force-pushed
the
string-generation
branch
from
c9777aa to
d3b7e7c
Compare
dwreeves
reviewed
Sep 8, 2023
Contributor
There was a problem hiding this comment.
Strictly speaking this is not a refactor as the - is always included in the new version, but not the old version.
uranusjr
approved these changes
Sep 8, 2023
eumiro
force-pushed
the
string-generation
branch
from
d3b7e7c to
13a53cc
Compare
potiuk
approved these changes
Sep 11, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit a1fe77b)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.