Fix the required permissions to clear a TI from the UI #34123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
Taragolis,
pierrejeambrun,
potiuk and
uranusjr
hussein-awala
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
2 tasks
potiuk
approved these changes
Sep 5, 2023
jedcunningham
approved these changes
Sep 5, 2023
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
I agree, bug. The API also requires edit.
Member
Yep. I looked it up in API first and saw EDIT - but missed the |
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 2f5777c)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34092
To clear a TI, we don't delete the row, but we just update some fields like the state, job_id, task_retries, ... so technically we edit it.
Currently the required permissions to do that are edit dag run and delete task instance, which is IMHO a bug. WDYT about that?
However this fix could affect some users who have roles with delete permission without edit, so we should be careful.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.