Remove duplicated logs by reusing PodLogsConsumer #34127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkim010
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
eladkal
reviewed
Sep 8, 2023
* reuse the kubernetes connection not to re-consume the logs
* If a failure occurs while consuming logs through `PodLogsConsumer`, a new `PodLogsConsumer` is created.
* But, at this time there are duplicated logs even though they have already been consumed.
* To fix the duplicated logs, `PodLogsConsumer` instance is created initially at once and is to reused
when a failure occurs to prevent duplicate logs from occurring.
Signed-off-by: 김동원 <dongwon.kim@toss.im>
dkim010
force-pushed
the
patch/reuse-connection-to-dedup-logs
branch
from
e1220a4 to
053ebae
Compare
Signed-off-by: 김동원 <dongwon.kim@toss.im>
Contributor
Author
|
I am waiting! Would you review this pull request? @hussein-awala @jedcunningham |
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Could you a unit test for this change?
added 2 commits
September 18, 2023 23:11
Signed-off-by: 김동원 <dongwon.kim@toss.im>
Signed-off-by: 김동원 <dongwon.kim@toss.im>
Contributor
Author
|
@hussein-awala Hussein, I am still waiting~~!! |
Contributor
Author
|
@jedcunningham Would you review this pull request? |
eladkal
approved these changes
Oct 1, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
98 tasks
dstandish
added a commit
that referenced
this pull request
Nov 13, 2023
We were passing around the `logs` variable (actually PodLogConsumer object) for no reason. And the `termination_timeout` param was not used. It seems that the passing around of the object was first introduced in #34127, then perhaps accidentally removed in #34127. Someone may want to try to re-introduce the original fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PodLogsConsumer, a newPodLogsConsumeris created.PodLogsConsumerinstance is created initially at once and is to reusedwhen a failure occurs to prevent duplicate logs from occurring.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.