Skip to content

Conversation

@Usiel
Copy link
Contributor

@Usiel Usiel commented Sep 6, 2023

closes #34132

When creating the feature request I was only thinking of the Graph tab. However, while playing with this I realized that whenever tab is set, the user will expect to see the details panel and the requested tab.

There are 2 main scenarios where a user would navigate to a link with the tab query param set:

  1. User clicks on one of the pills on the DAG view (Graph, Gantt, Code). Imo, the user will expect to see the relevant tab in the details panel, even if they have hid it previously.
  2. User clicks on a link (e.g. from DAG runs, or someone sharing a link). Less clear cut than scenario 1, but still I think the most user friendly result is to show the requested tab (in the details panel).

The behavior is so that we do not change the user's setting, if they go back to the grid view the details panel will be hidden if that was their original setting.

I think there is still room for improvement, the UI feels slightly inconsistent due to the different methods of achieving the same state. This PR is just a tiny change to (hopefully) make this a bit less confusing to the user.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 6, 2023
@bbovenzi
Copy link
Contributor

bbovenzi commented Sep 6, 2023

Good idea. I wonder if we want to get rid of the localStorage part of this then.

Also, mind to double check lint and type checks?

@Usiel
Copy link
Contributor Author

Usiel commented Sep 6, 2023

Good idea. I wonder if we want to get rid of the localStorage part of this then.

Hmm I was wondering if this was a remnant of a full page reload or similar, but after looking at #22123 I don't think that's the case. I think it would be fine to remove the localStorage usage and also not to remember this at all (-> revert back to showing the panel on a reload), but then again I never hid the panel on purpose, so maybe I'm not the target audience 😄

Also, mind to double check lint and type checks?

I reran the "Static checks" step (breeze static-checks --all-files --show-diff-on-failure --color always --initialize-environment) locally, all green here.
(The GitHub actions run failed due to timeout: "The job running on runner GitHub Actions 69 has exceeded the maximum execution time of 30 minutes.")

The query param `tab` is set on the DAGs view when any of the tabs _within_ the details panel is selected, thus we should show the details panel, even if the user previously hid it.

There are 2 main scenarios where a user would navigate to such a link:
1. User clicks on one of the pills on the DAG view (Graph, Gantt, Code). Imo, the user will expect to see the relevant tab in the details panel, even if they have it hidden.
2. User clicks on a link (e.g. from DAG runs, or someone sharing a link). Less clear cut than scenario 1, but still I think the most user friendly result is to show the requested tab (in the details panel).
@potiuk potiuk force-pushed the usiel/show-details-panel-for-graph-route branch from c8d4df1 to 7647f5a Compare September 6, 2023 20:54
@bbovenzi bbovenzi added this to the Airflow 2.7.2 milestone Sep 7, 2023
@bbovenzi bbovenzi merged commit 0b319e7 into apache:main Sep 7, 2023
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
The query param `tab` is set on the DAGs view when any of the tabs _within_ the details panel is selected, thus we should show the details panel, even if the user previously hid it.

There are 2 main scenarios where a user would navigate to such a link:
1. User clicks on one of the pills on the DAG view (Graph, Gantt, Code). Imo, the user will expect to see the relevant tab in the details panel, even if they have it hidden.
2. User clicks on a link (e.g. from DAG runs, or someone sharing a link). Less clear cut than scenario 1, but still I think the most user friendly result is to show the requested tab (in the details panel).

(cherry picked from commit 0b319e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Always show details panel when user navigates to Graph tab

3 participants