Skip to content

Conversation

@Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Sep 6, 2023

Due to changes in flask_appbuilder>=4.3.4 (dpgaspar/Flask-AppBuilder#2071) our logging messages turned into

[2023-09-06T06:59:50.725+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:537} INFO - Added Permission %s to role %s
[2023-09-06T06:59:50.737+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:484} INFO - Created Permission View: %s
[2023-09-06T06:59:50.740+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:537} INFO - Added Permission %s to role %s
[2023-09-06T06:59:50.744+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:484} INFO - Created Permission View: %s
[2023-09-06T06:59:50.746+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:537} INFO - Added Permission %s to role %s

Which do not produce any valuable information

After this fix:

[2023-09-06T17:20:05.744+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:537} INFO - Added Permission menu access on Resources to role Admin
[2023-09-06T17:20:05.756+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:484} INFO - Created Permission View: can read on Permission Views
[2023-09-06T17:20:05.759+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:537} INFO - Added Permission can read on Permission Views to role Admin
[2023-09-06T17:20:05.766+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:484} INFO - Created Permission View: menu access on Permission Pairs
[2023-09-06T17:20:05.769+0000] {/opt/airflow/airflow/auth/managers/fab/security_manager/modules/db.py:537} INFO - Added Permission menu access on Permission Pairs to role Admin

update: we bump FAB to 4.3.6 in #33931


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hussein-awala hussein-awala merged commit fb99f6c into apache:main Sep 6, 2023
@pankajkoti pankajkoti added this to the Airflow 2.7.2 milestone Sep 8, 2023
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants