Only tag :latest image when default python version is used #34182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only tag :latest image when default image is used because this step always tags `apache/airflow:X.Y.Z` (defaulti Python) to become the `apache/airflow:latest`. This step was previously run for all Python versions which could have two effects: * if non-default image completed before the default such tagging would fail as the `apache/airflow:X.Y.Z` was not ready yet to be used as target of `apache/airflow:latesti` tag * if non-default image completed later, it would be no-op because the `apache/airflow:latest` already pointed to `apache/airflow:X.Y.Z`
ephraimbuddy
approved these changes
Sep 7, 2023
jedcunningham
approved these changes
Sep 7, 2023
potiuk
added a commit
that referenced
this pull request
Sep 7, 2023
We should only tag :latest image when default image is used because this step always tags `apache/airflow:X.Y.Z` (defaulti Python) to become the `apache/airflow:latest`. This step was previously run for all Python versions which could have two effects: * if non-default image completed before the default such tagging would fail as the `apache/airflow:X.Y.Z` was not ready yet to be used as target of `apache/airflow:latesti` tag * if non-default image completed later, it would be no-op because the `apache/airflow:latest` already pointed to `apache/airflow:X.Y.Z` (cherry picked from commit 51d8b10)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only tag :latest image when default image is used because this step always tags
apache/airflow:X.Y.Z(defaulti Python) to become theapache/airflow:latest. This step was previously run for all Python versions which could have two effects:if non-default image completed before the default such tagging would fail as the
apache/airflow:X.Y.Zwas not ready yet to be used as target ofapache/airflow:latestitagif non-default image completed later, it would be no-op because the
apache/airflow:latestalready pointed toapache/airflow:X.Y.Z^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.