Skip to content

Replace assert by if...raise in www package #34249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hussein-awala merged 1 commit into from
Sep 9, 2023
Merged

Replace assert by if...raise in www package #34249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airflow/www/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2287,7 +2287,11 @@ def _clear_dag_tis(
except AirflowException as ex:
return redirect_or_json(origin, msg=str(ex), status="error", status_code=500)

assert isinstance(tis, collections.abc.Iterable)
if not isinstance(tis, collections.abc.Iterable):
raise AssertionError(
f"Expected dag.clear() to return an iterable for dry runs, got {tis} instead."
)

details = [str(t) for t in tis]

if not details:
Expand Down