-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Deprecate numeric type python version in PythonVirtualEnvOperator #34359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate numeric type python version in PythonVirtualEnvOperator #34359
Conversation
Remove float type python version in PythonVirtualEnvOperator
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Personally I’d even remove the int case, being able to pass We should add a news fragment for this. |
change deprecated to removed
change removal to deprecation
fix line too long
change condition statement
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…4359) * Remove float type python version in PythonVirtualEnvOperator Remove float type python version in PythonVirtualEnvOperator * Remove int type python version in PythonVirtualEnvOperator * change deprecated to removed change deprecated to removed * change removal to deprecation change removal to deprecation * fix typo fix typo * fix line too long fix line too long * change condition statement change condition statement * Use 'is not' --------- Co-authored-by: kyeonghoon Kim <kyeonghoon.kim@bagelcode.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit b23d3f9)
Deprecate float type python version in PythonVirtualEnvOperator.
If input is 3.10 as float, it is interpreted as python version 3.1.
Also deprecated int type because of consistency.
@BlueHorn07 found the issue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.