Skip to content

Conversation

@starone99
Copy link
Contributor

@starone99 starone99 commented Sep 14, 2023

Deprecate float type python version in PythonVirtualEnvOperator.
If input is 3.10 as float, it is interpreted as python version 3.1.

Also deprecated int type because of consistency.

@BlueHorn07 found the issue.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Remove float type python version in PythonVirtualEnvOperator
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 14, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

Personally I’d even remove the int case, being able to pass python_version=3 is not particularly useful and can be rewritten pretty trivially.

We should add a news fragment for this.

@starone99 starone99 changed the title Remove float type python version in PythonVirtualEnvOperator Remove numeric type python version in PythonVirtualEnvOperator Sep 14, 2023
change deprecated to removed
change removal to deprecation
@starone99 starone99 changed the title Remove numeric type python version in PythonVirtualEnvOperator Deprecate numeric type python version in PythonVirtualEnvOperator Sep 14, 2023
@eladkal eladkal added this to the Airflow 2.7.2 milestone Sep 15, 2023
change condition statement
@Taragolis Taragolis merged commit b23d3f9 into apache:main Sep 16, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 16, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@starone99 starone99 deleted the Remove-float-type-python-version-in-PythonVirtualEnvOperator branch September 17, 2023 05:12
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
…4359)

* Remove float type python version in PythonVirtualEnvOperator

Remove float type python version in PythonVirtualEnvOperator

* Remove int type python version in PythonVirtualEnvOperator

* change deprecated to removed

change deprecated to removed

* change removal to deprecation

change removal to deprecation

* fix typo

fix typo

* fix line too long

fix line too long

* change condition statement

change condition statement

* Use 'is not'

---------

Co-authored-by: kyeonghoon Kim <kyeonghoon.kim@bagelcode.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit b23d3f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants