Fix multiNamespaceMode not working with executor KubernetesExecutor #34505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuayeung
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
…utor-KubernetesExecutor
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Could you add a new test which simulates the issue you have with the current implementation? (in this module)
joshuayeung
force-pushed
the
Fix-multiNamespaceMode-not-working-with-executor-KubernetesExecutor
branch
2 times, most recently
from
346bd7e to
1819d53
Compare
joshuayeung
force-pushed
the
Fix-multiNamespaceMode-not-working-with-executor-KubernetesExecutor
branch
from
1819d53 to
6bc7ccf
Compare
Contributor
Author
Hi @hussein-awala , I have added a test case to test this scenario |
…utor-KubernetesExecutor
…utor-KubernetesExecutor
|
Thank you very much guys for this fix 🙏 |
Lee-W
approved these changes
Oct 4, 2023
…utor-KubernetesExecutor
Contributor
|
helm chart tests are failing |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, multiNamespaceMode is not working with executor KubernetesExecutor.
Even though we set the pod override in the executor config, the pod is still generated in the airflow namespace.
It is suggested to change the order of this pod list to make it work.
See more details:
#31990
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.