Deprecate lazy import AirflowException from airflow
#34541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
approved these changes
Sep 22, 2023
| warnings.warn( | ||
| f"Import {name!r} directly from the airflow module is deprecated and " | ||
| f"will be removed in the future. Please import it from 'airflow{module_path}.{attr_name}'.", | ||
| DeprecationWarning, |
Member
There was a problem hiding this comment.
Should use RemovedInAirflow3Warning isntead?
Contributor
Author
There was a problem hiding this comment.
It required to import from airflow.exceptions module 🙂, which might be a reason for circular import.
I guess for the same reason we do not use internal warning in airflow.configuration and use generic one
Lee-W
approved these changes
Sep 23, 2023
vincbeck
approved these changes
Oct 6, 2023
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up: #34512 (comment)
I've also check that there is no examples with
from airflow import AirflowExceptionin docs.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.