Skip to content

Use ExitStack to manage mutation of secrets_backend_list in dag.test #34620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dstandish merged 1 commit into from
Nov 27, 2023
Merged

Use ExitStack to manage mutation of secrets_backend_list in dag.test #34620

dstandish merged 1 commit into from
Nov 27, 2023

Conversation

@dstandish
Copy link
Contributor

@dstandish dstandish commented Sep 26, 2023 •
edited
Loading

Although it requires another indent, it's cleaner, and more importantly it makes sure that the mutation is undone after failure.

@eladkal eladkal added this to the Airflow 2.7.2 milestone Sep 29, 2023
@eladkal
Copy link
Contributor

eladkal commented Oct 29, 2023

@dstandish needs rebase

@eladkal eladkal added the type:improvement Changelog: Improvements label Nov 24, 2023
@dstandish
Use ExitStack to manage mutation of secrets_backend_list in dag.test
9a88a42 
Although it requires another indent, it's cleaner, and more importantly it makes sure that the mutation is undone after failure.
@dstandish dstandish force-pushed the use-exit-stack-for-sbl-mutation branch from 470c087 to 9a88a42 Compare November 27, 2023 15:05
@dstandish dstandish merged commit 99b4eb7 into apache:main Nov 27, 2023
@dstandish dstandish deleted the use-exit-stack-for-sbl-mutation branch November 27, 2023 19:07
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
@dstandish @ephraimbuddy
Use ExitStack to manage mutation of secrets_backend_list in dag.test (#…
ecbc959 
…34620)

Although it requires another indent, it's cleaner, and more importantly it makes sure that the mutation is undone after failure.

(cherry picked from commit 99b4eb7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladkal eladkal eladkal approved these changes

@kaxil kaxil Awaiting requested review from kaxil

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

@ashb ashb Awaiting requested review from ashb

Assignees

No one assigned

Labels

area:CLI type:improvement Changelog: Improvements

Projects

None yet

Milestone

Airflow 2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dstandish @eladkal @ephraimbuddy