Skip to content

Don't run isort when creating new alembic migrations #34636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uranusjr merged 1 commit into from
Sep 27, 2023
Merged

Don't run isort when creating new alembic migrations #34636

uranusjr merged 1 commit into from
Sep 27, 2023

Conversation

@jedcunningham
Copy link
Member

@jedcunningham jedcunningham commented Sep 27, 2023

We can let pre-commit do its thing instead of running specific static-check type things explicity. There are a number of things that could mutate the file before it's ready ultimately.

This is the error we get today, though the migration file is created:

  Generating /opt/airflow/airflow/migrations/versions/ff1136b2c21b_add_something.py ...  done
  Running post write hook 'isort' ...
  FAILED
[2023-09-27T00:46:38.441+0000] {messaging.py:70} ERROR - Could not find entrypoint console_scripts.isort
  FAILED: Could not find entrypoint console_scripts.isort

@jedcunningham
Don't run isort when creating new alembic migrations
4b943fd 
We can let pre-commit do its thing instead of running specific
static-check type things explicity. There are a number of things that
could mutate the file before it's ready ultimately.
@uranusjr uranusjr merged commit db89a33 into apache:main Sep 27, 2023
@uranusjr uranusjr deleted the fix_alembic_migration_creation branch September 27, 2023 06:46
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.2 milestone Oct 3, 2023
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
@jedcunningham @ephraimbuddy
Don't run isort when creating new alembic migrations (#34636)
04810cc 
(cherry picked from commit db89a33)
@ephraimbuddy ephraimbuddy mentioned this pull request Oct 9, 2023
Closed
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr approved these changes

@utkarsharma2 utkarsharma2 utkarsharma2 approved these changes

@amoghrajesh amoghrajesh amoghrajesh approved these changes

Assignees

No one assigned

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@jedcunningham @uranusjr @utkarsharma2 @amoghrajesh @ephraimbuddy