Skip to content

Standardise output of "airflow connections export" to those of "airflow variables export" and "airflow users export" #34640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hussein-awala merged 1 commit into from
Sep 27, 2023
Merged

Standardise output of "airflow connections export" to those of "airflow variables export" and "airflow users export" #34640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow/cli/commands/connection_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,9 @@ def connections_export(args):
f.write(msg)

if file_is_stdout:
print("\nConnections successfully exported.", file=sys.stderr)
print(f"\n{len(connections)} connections successfully exported.", file=sys.stderr)
Copy link
Contributor

@utkarsharma2 utkarsharma2 Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jayden-Chiu Not a blocker, How can we ensure that the output of export connection export variable and users export doesn't mismatch by any further changes in the codebase?

Can we add a single function to prepare a similar output?

Copy link
Member

@hussein-awala hussein-awala Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utkarsharma2 good point, could you open a new PR to do that?

Copy link
Contributor

@utkarsharma2 utkarsharma2 Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hussein-awala Sure, I'll raise that.

else:
print(f"Connections successfully exported to {args.file.name}.")
print(f"{len(connections)} connections successfully exported to {args.file.name}.")


alternative_conn_specs = ["conn_type", "conn_host", "conn_login", "conn_password", "conn_schema", "conn_port"]
Expand Down