Move cli's Connection export and Variable export command print logic to a seprate function #34647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also, can you please point me to the source of the |
Member
|
@utkarsharma2, it lives here now: |
uranusjr
reviewed
Oct 4, 2023
utkarsharma2
requested review from
Fokko,
XD-DENG,
ashb,
bolkedebruin,
eladkal,
jhtimmins,
josh-fell,
kaxil,
mik-laj,
o-nikolas,
pierrejeambrun and
potiuk
as code owners
utkarsharma2
force-pushed
the
StandardiseExportOutput
branch
2 times, most recently
from
cefc0fa to
646f06e
Compare
utkarsharma2
requested review from
uranusjr
and removed request for
XD-DENG,
bolkedebruin,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
jhtimmins,
josh-fell,
kaxil,
mik-laj,
o-nikolas and
pierrejeambrun
Contributor
Author
|
@uranusjr The failure on the PR don't look related. |
Contributor
please rebase and lets see how it looks now |
Contributor
Author
|
@eladkal All checks are passing now. |
uranusjr
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #34640
This PR attempts to move the output logic for
airflow connection exportandairflow variable exportto a separate function to ensure they don't unknowingly change in the future.